feat: Render validation messages for Form associated custom elements #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkaraivanov
added
enhancement
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
…/IgniteUI/igniteui-webcomponents into rkaraivanov/validation-container
…onents into rkaraivanov/validation-container
This comment was marked as resolved.
This comment was marked as resolved.
…ng end for material and change the icon
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Fixed timing issues for the igc-icon broadcast channel tests.
damyanpetev
reviewed
Oct 4, 2024
Comment on lines
+396
to
+425
| it('renders value-missing slot', async () => { | ||
| await createFixture(html` | ||
| <igc-checkbox required> | ||
| <div slot="value-missing"></div> | ||
| </igc-checkbox> | ||
| `); | ||
|
|
||
| await checkValidationSlots(element, 'valueMissing'); | ||
| }); | ||
|
|
||
| it('renders custom-error slot', async () => { | ||
| await createFixture(html` | ||
| <igc-checkbox> | ||
| <div slot="custom-error"></div> | ||
| </igc-checkbox> | ||
| `); | ||
|
|
||
| element.setCustomValidity('invalid'); | ||
| await checkValidationSlots(element, 'customError'); | ||
| }); | ||
|
|
||
| it('renders invalid slot', async () => { | ||
| await createFixture(html` | ||
| <igc-checkbox required> | ||
| <div slot="invalid"></div> | ||
| </igc-checkbox> | ||
| `); | ||
|
|
||
| await checkValidationSlots(element, 'invalid'); | ||
| }); |
There was a problem hiding this comment.
These could be entirely data driven (either separate tests or a single one) in a loop of slot names. Assuming checkValidationSlots will handle the slot name directly since it only converts them to kebab case anyway.
There was a problem hiding this comment.
Pretty much true for the rest of the components running this set of checks it seems.
Added aria-describedby for input/mask-input for the internal native input element when content is projected into the helper-text slot.
simeonoff
approved these changes
Oct 7, 2024
damyanpetev
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1195
Closes #1043
Specification here