-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expansion panel component #332
Conversation
…onents into expansion-panel/feat-177
|
||
private headerTemplate() { | ||
return html` | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ARIA design pattern wraps the button in a heading (must check if that's always reqruired), which this is missing. Also if we wrap it internally there's no control over the aria level which might be a bit of an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, in terms of accessibility - if there's no title/sub projected this will still render as an empty button that is still targetable by tab navigation which I'm not sure is ideal.
Speaking of, we used expansion panel in some scenarios without a header even and if such a scenario is also intended to be supported then the hardcoded header would not fit.
Tagging @sdimchevski as well for this and I'll look for the example without a header to add here so we can evaluate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay took a bit to dig up since this is (no longer?) embedded in the docs, but the first card in this sample is using an expansion panel:
https://www.infragistics.com/angular-demos/layouts/card-sample-4
Point being, it doesn't have a header and it's toggled by some external button that either need to be positioned by the Card layout or under the panel as in this case. So my question is would this be a case we should consider supporting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damyanpetev I don't know why this Card in the example is using an expansion panel. Expansion panels by design should have a header that acts as the control for expanding and collapsing. I believe you can have a card and implement your own collapsible mechanic through the use of button events but that's not in the scope of the expansion panel.
so who's going to remove the DO NOT MERGE label |
…onents into expansion-panel/feat-177
Closes #177