Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tabs component #341
Add tabs component #341
Changes from 19 commits
9a304b9
16dfafd
42899b0
263c920
6f37677
d37938c
1554c4c
3cbae96
9c5dba5
96cd2aa
5a4b94f
08da984
dae461c
c1816b3
097b369
366e04a
85da81f
452e1d6
72dc15c
3d65d9c
c1458ac
40eeea6
47e7dde
04c0b9f
42c12e8
571cc2e
dd01331
54b1aa7
4572eae
194593d
e7328a5
51d46df
1853be7
a94741d
6c0bbf9
86bfca4
c6e24f3
7b6dd45
74a8253
bdc0062
d37509e
3d22354
83e9716
43ce217
183b538
89f289a
b3696b4
7162b51
a2991b5
ed2fb51
4581887
a18196f
267208e
cfc0763
46bff71
82e3928
65379e6
c1eb4ab
77fcefb
7ffea4a
dcc14dd
b1c8517
8ef0fc7
08f41b3
a13ffa2
097e1e9
299b9cf
905e2f6
90c49d1
b40785d
115e738
f9d7e9c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see
aria-controls
linking to the panel the tab controls, the specs say 'should' but I think it might be needed to properly reflect the active tab when the focus is in the panel or its children.To that end - @rkaraivanov would it not make more sense to have
id
on the panel instead ofname
as the ARIA link is based on id-s anyway?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damyanpetev
Fine by me. Feel free to update the specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did though
aria-controls
is described as should have.Reading https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role we might also consider aria-owns list on the tabs themselves it seems as it's described as must
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tablist role is set for the parent element of the tabs so I believe we don't need the aria-owns attribute.