Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stepper component #437

Merged
merged 117 commits into from
Nov 22, 2022
Merged

Add stepper component #437

merged 117 commits into from
Nov 22, 2022

Conversation

viktorkombov
Copy link
Contributor

Closes #219

@viktorkombov viktorkombov marked this pull request as draft July 15, 2022 08:00
mmart1n and others added 26 commits July 18, 2022 13:42
feat(stepper): add display flex for demonstrational purpose
5e8728b
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
4210f2d 
…onents into vkombov/feat-219
feat(stepper): add initial layout and component properties
afd15f3
feat(stepper): add tests setup
c48bcb4
@desig9stein
feat(stepper): initial styling (#496)
7646d41 
Co-authored-by: mmart1n <mevtimov@infragistics.com>
feat(stepper): add step part for orientation
35310f4
@mmart1n
Merge branch 'master' into vkombov/feat-219
45ae391
@viktorkombov
refactor(stepper): Remove stepper from step
96c109a
@desig9stein
style(stepper): fix step styles
e704354 
- rearrange sass files
feat(stepper): add activate step basic functionality
7786408
@viktorkombov
feat(stepper): Add basic linear functionality
1307db1
rafactor(stepper): subscribe to events in constructor
7b951b9
@desig9stein
style(stepper): initial step content animations (#501)
8f00484
@desig9stein
style(stepper): fix some issues with body content
043930b
feat(stepper): init calculate stepper height dynamically
95c06ae
@desig9stein
style(stepper): fix content top body position in horizontal mode
7d67bf2
feat(stepper): calculate css vars initially
abb3555
@desig9stein
style(stepper): add initial separator styles
3ae8ed8
@desig9stein
Merge branch 'vkombov/feat-219' of https://github.com/IgniteUI/ignite…
1141e88 
…ui-webcomponents into vkombov/feat-219
@desig9stein
style(stepper): using grid
9fbe7b2
feat(stepper): set css vars for horizontal mode
55fce70
@desig9stein
style(stepper): fix separator position
4124163
feat(stepper): add initial aria and keyboard nav impl
1cc127b
feat(stepper): fix tab navigation
a6fd841
@viktorkombov
test(stepper): Init keyboard nav tests
548dd71
@desig9stein
style(stepper): restructure styles
489805e
@ChronosSF ChronosSF requested review from igdmdimitrov and gmurray81 and removed request for rkaraivanov November 8, 2022 09:33
simeonoff
simeonoff requested changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few comments and suggestions I have, everything else LGTM.

src/components/stepper/themes/step/light/step.base.scss Outdated Show resolved Hide resolved
src/components/stepper/themes/step/light/step.base.scss Outdated Show resolved Hide resolved
src/components/stepper/themes/step/light/step.base.scss Outdated Show resolved Hide resolved
src/components/stepper/themes/step/light/step.base.scss Outdated Show resolved Hide resolved
src/components/stepper/themes/stepper/stepper.base.scss Outdated Show resolved Hide resolved
@igdmdimitrov
Copy link
Contributor

Some of the texts are not visible in dark variant.

igdmdimitrov
igdmdimitrov requested changes Nov 16, 2022
View reviewed changes
src/components/stepper/step.ts Outdated Show resolved Hide resolved
src/components/stepper/step.ts Outdated Show resolved Hide resolved
src/components/stepper/step.ts Outdated Show resolved Hide resolved
src/components/stepper/stepper.ts Outdated Show resolved Hide resolved
src/components/stepper/stepper.ts Outdated Show resolved Hide resolved
@mmart1n mmart1n requested a review from igdmdimitrov November 16, 2022 14:08
@mmart1n
Copy link
Contributor

mmart1n commented Nov 16, 2022

Some of the texts are not visible in dark variant.

@desig9stein could you please take a look at this?

@desig9stein
Copy link
Contributor

Some of the texts are not visible in dark variant.

@desig9stein could you please take a look at this?

I don't see any problem with the texts. @igdmdimitrov Make sure that you have a dark background behind the stepper, otherwise, it is normal not to see the texts.

@teodosiah teodosiah merged commit 40aacc9 into master Nov 22, 2022
@teodosiah teodosiah deleted the vkombov/feat-219 branch November 22, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desig9stein desig9stein desig9stein left review comments

@igdmdimitrov igdmdimitrov igdmdimitrov approved these changes

@simeonoff simeonoff simeonoff approved these changes

@gmurray81 gmurray81 Awaiting requested review from gmurray81

Assignees

@ddaribo ddaribo

@MonikaKirkova MonikaKirkova

Labels
stepper ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepper Component
8 participants
@viktorkombov @simeonoff @igdmdimitrov @mmart1n @desig9stein @ddaribo @MonikaKirkova @teodosiah