Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(themes): use igniteui-theming package when generating themes #454

Merged
merged 45 commits into from
Oct 13, 2022
Merged

refactor(themes): use igniteui-theming package when generating themes #454

merged 45 commits into from
Oct 13, 2022

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jul 27, 2022 •
edited
Loading

Closes #115
Closes #415
Closes #506

@simeonoff simeonoff marked this pull request as draft July 27, 2022 10:29
@simeonoff simeonoff changed the title Igniteui theming refactor(themes): use igniteui-theming package when generating themes Jul 27, 2022
@simeonoff simeonoff requested a review from rkaraivanov August 16, 2022 12:44
@simeonoff simeonoff marked this pull request as ready for review August 16, 2022 12:44
simeonoff and others added 12 commits September 13, 2022 17:11
@simeonoff
Merge branch 'master' into igniteui-theming
d85954f
@simeonoff
npm(theming): bump to latest beta
995eb24
@simeonoff
refactor(dialog): migrate to theming package typography mixins
9bf1f72
@simeonoff
Merge branch 'master' into igniteui-theming
3d122c4
@simeonoff
Merge branch 'master' into igniteui-theming
c880d21
@simeonoff @desig9stein @SisIvanova
refactor(themes): size component using CSS vars (#484)
07eb026 
* refactor(avatar): use CSS for sizing

* Adding sizing (#498)

* refactor(button): to use sizing

* refactor(icon-button): to use sizing

* refactor(calendar): to use sizing

Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>

* refactor(components): size components using CSS vars (#502)

* refactor(components): size components using CSS vars

* refactor(input): size component using CSS vars

* fix(calendar): border-radius issue

* feat(spacing): customizable spacing using pad functions

* refactor(themes): remove igc-spacing variables

* npm(theming): bump to latest beta

* fix(checkbox): size changes in tree component

Co-authored-by: Marin Popov <desig9stein@users.noreply.github.com>
Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com>
Co-authored-by: sivanova <sivanova@infragistics.com>
@simeonoff
Merge branch 'master' into igniteui-theming
a00b242
@simeonoff
lint(styles): fix errors
853a126
@simeonoff
refactor(themes): update dark grid selector
ec8e354
@simeonoff
Merge branch 'master' into igniteui-theming
8ed4830
@simeonoff
build(theming): bump version
59bdfed
@simeonoff
refactor(scrollbar): class igc-scrollbar to ig-scrollbar
ef1fab8
rkaraivanov
rkaraivanov previously approved these changes Oct 12, 2022
View reviewed changes
@didimmova
Copy link
Contributor

  • In the calendar, the navigation part has 0 height and padding only (coming from box-sizing: border-box)
  • The helper text has margin-top in theming branch and no margin-top in the master branch (input, date time input)

@simeonoff
Copy link
Collaborator Author

  • In the calendar, the navigation part has 0 height and padding only (coming from box-sizing: border-box)
  • The helper text has margin-top in theming branch and no margin-top in the master branch (input, date time input)

Yes, those were bugs in master.

@simeonoff simeonoff merged commit 000a982 into master Oct 13, 2022
@simeonoff simeonoff deleted the igniteui-theming branch October 13, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova approved these changes

@rkaraivanov rkaraivanov rkaraivanov left review comments

Assignees

@didimmova didimmova

Labels
refactoring squash-merge ✅ status: verified
Projects
None yet
Milestone
No milestone
5 participants
@simeonoff @didimmova @rkaraivanov @SisIvanova @desig9stein