refactor: Reduced LTR query calls and improved rating rendering #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted `isLTR` to an external helper function. - Reduced number of LTR query calls in certain scenarios to avoid reflow thrashing. - Cached rating symbols rendering logic. Properties not related to the symbols state will not trigger a DOM re-render.
|
@rkaraivanov hover preview with single selection doesn't seem to work as intended in this PR. The previously selected symbol stays colored even after changing the selection. |
simeonoff
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLTRto an external helper function.reflow thrashing.
to the symbols state will not trigger a DOM re-render.