Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(select): keyboard behavior matches angular #495

Merged
merged 5 commits into from
Sep 1, 2022
Merged

refactor(select): keyboard behavior matches angular #495

merged 5 commits into from
Sep 1, 2022

Conversation

simeonoff
Copy link
Collaborator

No description provided.

@simeonoff simeonoff requested a review from rkaraivanov August 26, 2022 11:14
@simeonoff simeonoff marked this pull request as ready for review August 26, 2022 11:14
@rkaraivanov
Copy link
Member

@simeonoff
LGTM, however when the dropdown is opened, the left/right keys don't seem to mimic the up/down keys correctly. For example, it cannot skip over disabled items.

@simeonoff
Copy link
Collaborator Author

simeonoff commented Sep 1, 2022 •
edited
Loading

@simeonoff
LGTM, however when the dropdown is opened, the left/right keys don't seem to mimic the up/down keys correctly. For example, it cannot skip over disabled items.

Should work fine now. Had to update the dropdown keyboard handlers as well to enable support for navigation with left and right arrow keys.

@rkaraivanov rkaraivanov merged commit 17fe2ba into master Sep 1, 2022
@rkaraivanov rkaraivanov deleted the simeonoff/select-keyboar-nav branch September 1, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees
No one assigned
Labels
select ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simeonoff @rkaraivanov