Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): Range selection a11y improvement #497

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

rkaraivanov
Copy link
Member

Closes #476

@rkaraivanov rkaraivanov added a11y When the issue or PR is related to accessibility ❌ status: awaiting-test calendar labels Aug 30, 2022
@ChronosSF ChronosSF self-assigned this Aug 30, 2022
@ChronosSF
Copy link
Member

ChronosSF commented Aug 30, 2022

nvda reads the range values really well when the range is selected but while the user is choosing the range with the keyboard it reads the first selected date while the second is presented just by its position and weekday. Something like:

Selected Aug 18, 2022 . Not selected column 5 wednesday

Can we have the readout work while the user is choosing what to select as the second date in the range? Basically repeating the select behavior but leaving "unselected" so that he knows he hasn't yet confirmed the selection by just navigating with the arrow keys.

@ChronosSF
Copy link
Member

Sounds good now, even with the windows narrator.

@desig9stein , will you be able to test it with the Mac narrator?

@desig9stein
Copy link
Contributor

I can hear the mac narrator reading the range, however, I can't hear anything about the current date. In angular calendar when I go over the current date the narrator reads something like "23 September 2022 Current date"

@ChronosSF
Copy link
Member

@desig9stein , can we merge it like this and have a separate issue so that we don't block the release?

@ChronosSF ChronosSF merged commit 9e9db8f into master Sep 2, 2022
@ChronosSF ChronosSF deleted the rkaraivanov/fix-476 branch September 2, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y When the issue or PR is related to accessibility calendar squash-merge ✅ status: verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar accessibility improvements
4 participants