Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox/radio/switch): extra margin without label #553

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix(checkbox/radio/switch): extra margin without label #553

merged 2 commits into from
Nov 18, 2022

Conversation

SisIvanova
Copy link
Contributor

Closes #549

@SisIvanova SisIvanova requested a review from simeonoff November 18, 2022 08:21
@SisIvanova SisIvanova changed the title fix(checkbox/radio/switch ): extra margin without label fix(checkbox/radio/switch): extra margin without label Nov 18, 2022
simeonoff
simeonoff requested changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I like the brevity of the property being named just hide, it's not very descriptive as to what this state is being used for. Perhaps hideLabel is more befitting for this occasion.

src/components/checkbox/checkbox-base.ts Outdated Show resolved Hide resolved
src/components/radio/radio.ts Outdated Show resolved Hide resolved
@simeonoff simeonoff self-assigned this Nov 18, 2022
@simeonoff simeonoff merged commit fcadaa1 into master Nov 18, 2022
@simeonoff simeonoff deleted the sivanova/hide-empty-slots branch November 18, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@simeonoff simeonoff

@desig9stein desig9stein

Labels
checkbox radio switch ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox, radio, and switch controls have label margin even when there is no label
3 participants
@SisIvanova @simeonoff @desig9stein