build: Updated to TS 4.9 and build chain #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkaraivanov
added
documentation
damyanpetev
reviewed
Nov 30, 2022
| @@ -43,6 +41,8 @@ export default class IgcIconComponent extends SizableMixin(LitElement) { | |||
| * | |||
| * @attr [name=""] | |||
| */ | |||
| @property() | |||
| @alternateName('iconName') | |||
There was a problem hiding this comment.
@rkaraivanov This seems to mess with the current function of @alternateName, seems to be read off of setters only.
// CC @gmurray81
There was a problem hiding this comment.
Actually, /* alternateName: iconName */ on the setter seems to also do the job, so we might default to that
damyanpetev
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some issue with the Lit linting tools with the latest TS version.
That's why there is bunch of
@attrtags for public properties that are also attributes.