Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dangling references after element disconnect #608

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix: Dangling references after element disconnect #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a5156d
fix: Dangling references after element disconnect
rkaraivanov Jan 9, 2023
6b2798d
Merge branch 'master' into rkaraivanov/dangling-theme-controller-fix
simeonoff Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/checkbox/checkbox-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export class IgcCheckboxBaseComponent extends EventEmitterMixin<

public override disconnectedCallback() {
this.removeEventListener('keyup', this.handleKeyUp);
super.disconnectedCallback();
}

protected handleKeyUp() {
Expand Down
1 change: 1 addition & 0 deletions src/components/radio/radio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export default class IgcRadioComponent extends EventEmitterMixin<

public override disconnectedCallback() {
this.removeEventListener('keyup', this.handleKeyUp);
super.disconnectedCallback();
}

protected handleKeyUp() {
Expand Down
1 change: 1 addition & 0 deletions src/components/select/select-group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default class IgcSelectGroupComponent extends IgcDropdownGroupComponent {

public override disconnectedCallback() {
this.observer.disconnect();
super.disconnectedCallback();
}

protected override getParent() {
Expand Down
1 change: 1 addition & 0 deletions src/components/slider/slider-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ export class IgcSliderBaseComponent extends LitElement {

public override disconnectedCallback() {
this.removeEventListener('keyup', this.handleKeyUp);
super.disconnectedCallback();
}

protected handleKeyUp() {
Expand Down