Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepper): add animations #886

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Conversation

simeonoff
Copy link
Collaborator

Closes #861

@simeonoff simeonoff requested a review from SisIvanova August 18, 2023 11:11
@simeonoff simeonoff changed the title feat(stepper): add horizontal animations feat(stepper): add animations Aug 18, 2023
@simeonoff simeonoff marked this pull request as ready for review August 22, 2023 08:00
@SisIvanova
Copy link
Contributor

If we want to be consistent with Ignite UI for Angular the default animation duration should be 320ms. There is also a difference in the fade animation - in Ignite UI for Angular there is no leave animation (fade out) but here we animate both the current (fade out) and the next step (fade in).

@ChronosSF ChronosSF merged commit b41250c into master Aug 28, 2023
@ChronosSF ChronosSF deleted the simeonoff/stepper-animations branch August 28, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Implement Animations
4 participants