Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(input): bind dark themes to shadow root #940

Merged
merged 63 commits into from
Oct 23, 2023
Merged

refactor(input): bind dark themes to shadow root #940

merged 63 commits into from
Oct 23, 2023

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Oct 6, 2023 •
edited
Loading

Closes #954

simeonoff and others added 30 commits October 6, 2023 12:41
@simeonoff
refactor(input): bind dark themes to shadow root
eb97fa9
@simeonoff
refactor(expansion-panel): bind dark themes to component
436b413
@simeonoff
refactor(icon): bind dark themes to shadow root
dca436c
@desig9stein
refactor(rating): consume colors from schema
834bce8 
- update to the last version of igniteui-theming.
- use the new approach for dark themes.
@desig9stein
refactor(select): dark themes and file structure.
5d7dd9e
@desig9stein
refactor(slider): dark themes and file structure.
81a9c8b
@simeonoff
refactor(list): bind dark themes to shadowRoot
da4e9f6
@simeonoff
Merge branch 'simeonoff/refactor-dark-themes' of github.com:IgniteUI/…
65fad57 
…igniteui-webcomponents into simeonoff/refactor-dark-themes
@simeonoff
deps(theming): bump to latest version
931a4ae
@simeonoff
refactor(nav-drawer): bind dark themes to shadowRoot
a41b1ec
@SisIvanova
refactor(badge): bind dark themes to shadowRoot
6502e2b
@desig9stein
refactor(snackbar): dark themes and file structure.
0528cab
@desig9stein
refactor(stepper): dark themes and file structure.
661e861
@desig9stein
refactor(tabs): dark themes and file structure.
6cceed2
@desig9stein
refactor(tabs): remove unnecessary variables include
6b0075a
@SisIvanova
refactor(button): bind dark themes to shadowRoot
0b816e2
@simeonoff
refactor(navbar): bind dark themes to shadowRoot
62e0a5a
@desig9stein
refactor(*): cleanup unnecessary variables imports.
9dd4851
@desig9stein
refactor(toast): dark themes and file structure.
bffa761
@desig9stein
refactor(tree): dark themes and file structure.
d59cd4c
@simeonoff
refactor(radio): bind dark themes to shadowRoot
da750c2
@SisIvanova
refactor(card): bind dark themes to shadowRoot
365bfbd
@SisIvanova
fix(badge/button): duplicated styles
9baaf4e
@simeonoff
Merge branch 'simeonoff/refactor-dark-themes' of github.com:IgniteUI/…
ed97254 
…igniteui-webcomponents into simeonoff/refactor-dark-themes
@simeonoff
Merge branch 'simeonoff/refactor-dark-themes' of github.com:IgniteUI/…
aff04a6 
…igniteui-webcomponents into simeonoff/refactor-dark-themes
@SisIvanova
refactor(checkbox/switch): bind dark themes to shadowRoot
f8a7b5a
@SisIvanova
refactor(chip): bind dark themes to shadowRoot
112b343
@SisIvanova
refactor(dialog): bind dark themes to shadowRoot
bf284d7
@SisIvanova
refactor(combo): bind dark themes to shadowRoot
bd5cf69
@SisIvanova
refactor(card): remove leftovers
82f9a53
@simeonoff simeonoff marked this pull request as ready for review October 23, 2023 08:14
@simeonoff simeonoff requested a review from rkaraivanov October 23, 2023 08:14
rkaraivanov
rkaraivanov previously approved these changes Oct 23, 2023
View reviewed changes
@simeonoff simeonoff requested a review from rkaraivanov October 23, 2023 14:23
@rkaraivanov rkaraivanov merged commit e3bab8f into master Oct 23, 2023
4 checks passed
@rkaraivanov rkaraivanov deleted the simeonoff/refactor-dark-themes branch October 23, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees
No one assigned
Labels
squash-merge themes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Themes: Dark component themes should be bound to shadowRoot
4 participants
@simeonoff @SisIvanova @rkaraivanov @desig9stein