feat: Refactor toggle directive into popover component #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents into rkaraivanov/popover-component
…onents into rkaraivanov/popover-component
* rewritten unit tests for main scenarios * fixed an issue with keyboard shortcuts * extracted a base option-like class for dropdown item and select item * utility classes refactoring
…onents into rkaraivanov/popover-component
…niteUI/igniteui-webcomponents into rkaraivanov/popover-component
…onents into rkaraivanov/popover-component
…onents into rkaraivanov/popover-component
…onents into rkaraivanov/popover-component
* Improved behavior to mimic the native select * WAI-ARIA improvements * Unit tests improvements There are still several areas where the logic can be streamlined with the dropdown and the common combolike ancestor. Next commits will address that, but this can be reviewed now.
Transfered old inherited props to igc-select
gedinakova
requested changes
Dec 1, 2023
gedinakova
reviewed
Dec 1, 2023
…onents into rkaraivanov/popover-component
…niteUI/igniteui-webcomponents into rkaraivanov/popover-component
rkaraivanov
added
enhancement
…onents into rkaraivanov/popover-component
simeonoff
reviewed
Dec 4, 2023
simeonoff
previously approved these changes
Dec 4, 2023
gedinakova
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.