Fix _tide_pwd when the user's HOME contains spaces.
#482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Windows system, for whatever reason, my `HOME` is `C:\Users\Alex Rønne Petersen` rather than the usual `C:\Users\alex` kind of thing you'd expect. (And yes, this has found a great many bugs in various pieces of software. 😄) This would lead to more and more errors the deeper into a directory I went: ``` ❯ cd /z ❯ cd Source string replace: too many arguments ❯ cd tests string replace: too many arguments string replace: too many arguments ❯ cd cs string replace: too many arguments string replace: too many arguments string replace: too many arguments ❯ cd bin string replace: too many arguments string replace: too many arguments string replace: too many arguments string replace: too many arguments ``` Quoting the use of `$HOME` here fixes the issue.
|
I'm new to fish and barely have any idea what I'm doing, so hopefully this change makes sense. 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Windows system, for whatever reason, my
HOMEisC:\Users\Alex Rønne Petersenrather than the usualC:\Users\alexkind of thing you'd expect. (And yes, this has found a great many bugs in various pieces of software. 😄)This would lead to more and more errors the deeper into a directory I went:
Quoting the use of
$HOMEhere fixes the issue.Description
Motivation and Context
Closes #
Screenshots (if appropriate)
How Has This Been Tested
Checklist