Merge pull request #89 from nyaruka/ivr_redaction_fix

Fix redaction of twiml IVR channel logs
Ilhasoft · Jun 20, 2023 · 7f9c61d · 7f9c61d
2 parents 237b665 + 45a1f4a
commit 7f9c61d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/services/ivr/twiml/service.go b/services/ivr/twiml/service.go
@@ -530,5 +530,8 @@ func ResponseForSprint(cfg *runtime.Config, urn urns.URN, resumeURL string, es [
 }
 
 func (s *service) RedactValues(ch *models.Channel) []string {
-	return []string{ch.ConfigValue(authTokenConfig, "")}
+	return []string{
+		httpx.BasicAuth(ch.ConfigValue(accountSIDConfig, ""), ch.ConfigValue(authTokenConfig, "")),
+		ch.ConfigValue(authTokenConfig, ""),
+	}
 }
diff --git a/services/ivr/twiml/service_test.go b/services/ivr/twiml/service_test.go
@@ -144,5 +144,5 @@ func TestRedactValues(t *testing.T) {
 	ch := oa.ChannelByUUID(testdata.TwilioChannel.UUID)
 	svc, _ := ivr.GetService(ch)
 
-	assert.Equal(t, []string{"sesame"}, svc.RedactValues(ch))
+	assert.Equal(t, []string{"U0lEMTIzNDU2Nzg5OnNlc2FtZQ==", "sesame"}, svc.RedactValues(ch))
 }