Merge pull request rapidpro#502 from nyaruka/no_more_webhook_results

No more webhook results

core/handlers/webhook_called.go

@@ -58,18 +58,5 @@ func handleWebhookCalled(ctx context.Context, tx *sqlx.Tx, rp *redis.Pool, oa *m
 		scene.AppendToEventPreCommitHook(hooks.InsertHTTPLogsHook, httpLog)
 	}
 
-	// TODO drop this once RP UI is switched to using HTTP logs
-	response := event.Response
-	if event.Status == flows.CallStatusConnectionError {
-		response = "connection error"
-	}
-	result := models.NewWebhookResult(
-		oa.OrgID(), scene.ContactID(),
-		event.URL, event.Request,
-		event.StatusCode, response,
-		time.Millisecond*time.Duration(event.ElapsedMS), event.CreatedOn(),
-	)
-	scene.AppendToEventPreCommitHook(hooks.InsertWebhookResultHook, result)
-
 	return nil
 }

core/handlers/webhook_called_test.go

@@ -72,26 +72,6 @@ func TestWebhookCalled(t *testing.T) {
 					SQL:   "select count(*) from request_logs_httplog where log_type = 'webhook_called' AND flow_id IS NOT NULL AND status_code = 410",
 					Count: 3,
 				},
-				{
-					SQL:   "select count(*) from api_webhookresult where contact_id = $1 AND status_code = 200",
-					Args:  []interface{}{testdata.Cathy.ID},
-					Count: 1,
-				},
-				{
-					SQL:   "select count(*) from api_webhookresult where contact_id = $1 AND status_code = 410",
-					Args:  []interface{}{testdata.Cathy.ID},
-					Count: 1,
-				},
-				{
-					SQL:   "select count(*) from api_webhookresult where contact_id = $1",
-					Args:  []interface{}{testdata.George.ID},
-					Count: 3,
-				},
-				{
-					SQL:   "select count(*) from api_webhookresult where contact_id = $1",
-					Args:  []interface{}{testdata.George.ID},
-					Count: 3,
-				},
 				{
 					SQL:   "select count(*) from api_webhookevent where org_id = $1",
 					Args:  []interface{}{testdata.Org1.ID},