Merge pull request #53 from nyaruka/ivr_log_body_fix

Fix not logging bodies of incoming IVR requests
Ilhasoft · Apr 3, 2023 · d10bf7e · d10bf7e
2 parents 9186d95 + ba38a87
commit d10bf7e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/web/ivr/ivr.go b/web/ivr/ivr.go
@@ -57,15 +57,15 @@ func newIVRHandler(handler ivrHandlerFn, logType models.ChannelLogType) web.Hand
 			return writeGenericErrorResponse(w, errors.Wrapf(err, "unable to get service for channel: %s", ch.UUID()))
 		}
 
-		// validate this request's signature
-		err = svc.ValidateRequestSignature(r)
+		recorder, err := httpx.NewRecorder(r, w, true)
 		if err != nil {
-			return svc.WriteErrorResponse(w, errors.Wrapf(err, "request failed signature validation"))
+			return svc.WriteErrorResponse(w, errors.Wrapf(err, "error reading request body"))
 		}
 
-		recorder, err := httpx.NewRecorder(r, w, true)
+		// validate this request's signature
+		err = svc.ValidateRequestSignature(r)
 		if err != nil {
-			return errors.Wrapf(err, "error reading request body")
+			return svc.WriteErrorResponse(w, errors.Wrapf(err, "request failed signature validation"))
 		}
 
 		clog := models.NewChannelLogForIncoming(logType, ch, recorder, svc.RedactValues(ch))