Fixed memory leak when reading character cards. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManlyMarco
approved these changes
Feb 25, 2024
|
Hi @takahiro0327 @ManlyMarco will this fix be added in a BrowserFolders or IllusionFixes update? |
|
This is an API change and only requires update to the API plugin. |
|
I know you've probably solved the problem, but just in case, I'll leave you with a link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that caused character card data to leak.
Please merge if it looks OK.
One of the following causes.
ManlyMarco/Illusion_BrowserFolders#35
Checked in KK/KKS, memory keeps increasing in KK when clicking [Refresh thumbnails].Something is still leaking.In KKS the memory increase stopped.I must have missed something, it was fixed in KK too.
Before: Each click increases the memory used by 200 MB.
After:
