Pallet Fellowship

Cargo.toml

@@ -8,9 +8,10 @@ members = [
 	'node',
 	"pallets/proposals",
 	"pallets/briefs",
-	"pallets/grants",
-	"pallets/crowdfunding",
-	"pallets/deposits",
+  	"pallets/grants",
+  	"pallets/crowdfunding",
+  	"pallets/deposits",
+  	"pallets/fellowship",
 	"runtime/integration-tests",
 	"runtime/imbue-kusama",
 	"runtime/common",

libs/common-traits/src/lib.rs

@@ -89,3 +89,9 @@ pub trait TokenMetadata {
 
     fn decimals(&self) -> u8;
 }
+
+/// Fallible conversion trait returning an [Option]. Generic over both source and destination types.
+pub trait MaybeConvert<A, B> {
+    /// Attempt to make conversion.
+    fn maybe_convert(a: A) -> Option<B>;
+}

pallets/briefs/Cargo.toml

@@ -2,7 +2,7 @@
 name = "pallet-briefs"
 authors = ['Imbue <https://github.com/ImbueNetwork>']
 description = "Briefs pallet is used to create a piece of work (briefs) to be done by a freelancer"
-version = '0.1.0'
+version = '1.0.0'
 license = 'Apache 2.0'
 homepage = 'https://github.com/ImbueNetwork/imbue'
 repository = "https://github.com/ImbueNetwork/imbue"

pallets/briefs/src/benchmarking.rs

@@ -16,7 +16,7 @@ use sp_std::{convert::TryInto, str, vec::Vec};
 
 const SEED: u32 = 0;
 
-#[benchmarks( where<T as frame_system::Config>::AccountId: AsRef<[u8]>,)]
+#[benchmarks( where <T as frame_system::Config>::AccountId: AsRef<[u8]>,)]
 mod benchmarks {
     use super::*;
 

pallets/briefs/src/lib.rs

@@ -310,6 +310,7 @@ pub mod pallet {
             ensure!(who == brief.applicant, Error::<T>::MustBeApplicant);
 
             let contributions = BriefContributions::<T>::get(brief_id);
+            let refund locations: Vec<(Multilocation, Percent)> = Vec::new();
 
             <T as Config>::DepositHandler::return_deposit(brief.deposit_id)?;
 

pallets/briefs/src/todo

@@ -0,0 +1,3 @@
+
+add field on Brief for require fellowship
+minimum contribution on a brief

pallets/crowdfunding/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "pallet-crowdfunding"
-version = "0.1.0"
+version = "1.0.0"
 description = "Used to setup the state for a proposal to morph into a project."
 authors = ['Imbue <https://github.com/ImbueNetwork>']
 homepage = 'https://github.com/ImbueNetwork/imbue'

pallets/deposits/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "pallet-deposits"
-version = "4.0.0-dev"
+version = "1.0.0"
 description = "A very simple pallet used to deal with storage deposits of a type."
 authors = ["Imbue Network"]
 homepage = 'https://github.com/ImbueNetwork/imbue'

pallets/fellowship/Cargo.toml

@@ -0,0 +1,56 @@
+[package]
+name = "pallet-fellowship"
+version = "0.1.0"
+description = "Used to map the accounts to a fellowship role. Encompasses all the functionality associated with fellowship decisions."
+authors = ["Substrate DevHub <https://github.com/substrate-developer-hub>"]
+license = 'Apache 2.0'
+homepage = 'https://github.com/ImbueNetwork/imbue'
+repository = "https://github.com/ImbueNetwork/imbue"
+edition = '2018'
+resolver = "2"
+
+[package.metadata.docs.rs]
+targets = ["x86_64-unknown-linux-gnu"]
+
+[dependencies]
+codec = { package = "parity-scale-codec", version = "3.2.2", default-features = false, features = [
+	"derive",
+] }
+scale-info = { version = "2.1.1", default-features = false, features = ["derive"] }
+frame-benchmarking = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43", default-features = false, optional = true }
+frame-support = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43", default-features = false }
+frame-system = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43", default-features = false }
+orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v0.9.43", default-features = false }
+common-types = { path = "../../libs/common-types", default-features = false}
+common-traits = { path = "../../libs/common-traits", default-features = false }
+sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43", default-features = false}
+sp-std = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43", default-features = false }
+
+[dev-dependencies]
+sp-core = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43"}
+sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43"}
+sp-io = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43"}
+common-types = { path = "../../libs/common-types"}
+common-traits = { path = "../../libs/common-traits"}
+orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v0.9.43"}
+orml-tokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v0.9.43"}
+sp-std = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43"}
+sp-arithmetic = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.43"}
+
+[features]
+default = ["std"]
+std = [
+	"codec/std",
+	"frame-benchmarking?/std",
+	"frame-support/std",
+	"frame-system/std",
+	"scale-info/std",
+	"sp-runtime/std",
+	"sp-std/std",
+]
+
+runtime-benchmarks = [
+	"frame-benchmarking/runtime-benchmarks",
+]
+
+try-runtime = ["frame-support/try-runtime"]

pallets/fellowship/src/benchmarking.rs

@@ -0,0 +1,116 @@
+#![cfg(feature = "runtime-benchmarks")]
+
+use super::*;
+use crate::Pallet as Fellowship;
+use crate::{traits::FellowshipHandle, Role, Config};
+use common_types::CurrencyId;
+use frame_benchmarking::{v2::*};
+use frame_support::assert_ok;
+use frame_system::RawOrigin;
+use orml_traits::{MultiCurrency, MultiReservableCurrency};
+use sp_runtime::SaturatedConversion;
+use frame_system::Pallet as System;
+
+
+#[benchmarks( where <T as frame_system::Config>::AccountId: AsRef<[u8]>, crate::Event::<T>: Into<<T as frame_system::Config>::RuntimeEvent>)]
+#[benchmarks]
+mod benchmarks {
+	use super::*;
+    #[benchmark]
+    fn add_to_fellowship() {
+        let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+        let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+
+        #[block]
+        {
+            <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&alice, Role::Vetter, 10, Some(&bob), true);
+        }
+        System::<T>::assert_last_event(Event::<T>::FellowshipAdded{who: alice.clone(), role: Role::Vetter}.into());
+    }
+
+     #[benchmark]
+     fn force_add_fellowship() {
+         let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+         #[extrinsic_call]
+         force_add_fellowship(RawOrigin::Root, alice.clone(), Role::Freelancer, 10);
+         System::<T>::assert_last_event(Event::<T>::FellowshipAdded{who: alice.clone(), role: Role::Vetter}.into());
+     }
+
+     #[benchmark]
+     fn leave_fellowship() {
+         let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+         let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+         <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&alice, Role::Vetter, 10, Some(&bob), true);
+
+         #[extrinsic_call]
+         leave_fellowship(RawOrigin::Signed(alice.clone()));
+
+         System::<T>::assert_last_event(Event::<T>::FellowshipRemoved{who: alice.clone()}.into());
+     }
+
+     #[benchmark]
+     fn force_remove_and_slash_fellowship() {
+         let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+         let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+         <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&alice, Role::Vetter, 10, Some(&bob), true);
+
+         #[extrinsic_call]
+         force_remove_and_slash_fellowship(RawOrigin::Root, alice.clone());
+         System::<T>::assert_last_event(Event::<T>::FellowshipRemoved{who: alice.clone()}.into());
+     }
+
+
+     #[benchmark]
+     fn add_candidate_to_shortlist() {
+         let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+         let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+         <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&alice, Role::Vetter, 10, Some(&bob), true);
+
+         #[extrinsic_call]
+         add_candidate_to_shortlist(RawOrigin::Signed(alice), bob.clone(), Role::Vetter, 10);
+         System::<T>::assert_last_event(Event::<T>::CandidateAddedToShortlist{who: bob.clone()}.into());
+     }
+
+     #[benchmark]
+     fn remove_candidate_from_shortlist() {
+         let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+         let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+         <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&alice, Role::Vetter, 10, Some(&bob), true);
+         Fellowship::<T>::add_candidate_to_shortlist(RawOrigin::Signed(alice.clone()).into(), bob.clone(), Role::Vetter, 10);
+
+         #[extrinsic_call]
+         remove_candidate_from_shortlist(RawOrigin::Signed(alice), bob.clone());
+         System::<T>::assert_last_event(Event::<T>::CandidateRemovedFromShortlist{who: bob}.into());
+     }
+
+     #[benchmark]
+     fn pay_deposit_to_remove_pending_status() {
+        let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1);
+        let alice: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+        let charlie: T::AccountId = create_funded_user::<T>("alice", 1, 1_000_000_000_000_000_000u128);
+
+        <crate::Pallet<T> as FellowshipHandle<<T as frame_system::Config>::AccountId>>::add_to_fellowship(&bob, Role::Vetter, 10, Some(&charlie), true);
+        let bob: T::AccountId = create_funded_user::<T>("bob", 1, 1_000_000_000_000_000_000u128);
+
+        #[extrinsic_call]
+        pay_deposit_to_remove_pending_status(RawOrigin::Signed(bob.clone()));
+        System::<T>::assert_last_event(Event::<T>::FellowshipAdded{who: bob, role: Role::Vetter}.into());
+    }
+
+    impl_benchmark_test_suite!(Fellowship, crate::mock::new_test_ext(), crate::mock::Test);
+}
+
+
+pub fn create_funded_user<T: Config>(
+    seed: &'static str,
+    n: u32,
+    balance_factor: u128,
+) -> T::AccountId {
+    let user = account(seed, n, 0);
+    assert_ok!(<T::MultiCurrency as MultiCurrency<
+        <T as frame_system::Config>::AccountId,
+    >>::deposit(
+        CurrencyId::Native, &user, balance_factor.saturated_into()
+    ));
+    user
+}