pallet-fellowship 2 #203
Merged
pallet-fellowship 2 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
btw This isnt put into the runtime yet, just the pallet has been made. |
samelamin
reviewed
Sep 5, 2023
| } | ||
| Ok(()) | ||
| } | ||
| fn ensure_role_in( |
There was a problem hiding this comment.
cant we use one function
seems both are similar except one checks a vec?
Are you concerned about the potential compute/block time?
There was a problem hiding this comment.
The idea behind this was so we can just use an ensure_role_in instead of doing multiple ensure_role
As for compute time i guess its the developers responsibility to ensure the input isn't from the user and isn't over bounds.
samelamin
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseding #179
Ripping the fellowship pallet into its own branch as a couple features that are on the main fellowship branch were there for testing.
Issue: #151