Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rococo admin #222

Merged
merged 19 commits into from
Sep 22, 2023
Merged

Rococo admin #222

merged 19 commits into from
Sep 22, 2023

Conversation

f-gate
Copy link
Member

@f-gate f-gate commented Sep 20, 2023 •
edited
Loading

solves: #178

Purpose

  • The use of Executive instead of blanket hooks for runtime upgrades
  • Use proper syntax for on runtime upgrades
  • inclusion of sudo for production fix

Storage Version migrations:

  • pallet-proposals
  • pallet-briefs
  • pallet-grants
  • ALL included into executive

Notes

pallet-proposals versioning

@ time of writing pallet Rococo is at v3 while Kusama is at v4
Currently the Executive of this branch is including the v4 migration.

samelamin and others added 18 commits August 25, 2023 11:50
@samelamin
add back sudo to rococo
802926e
@samelamin
Merge branch 'main' into rococo_admin
da988ce 
# Conflicts:
#	pallets/briefs/src/benchmarking.rs
#	pallets/crowdfunding/src/benchmarking.rs
#	pallets/proposals/src/tests.rs
#	runtime/integration-tests/src/constants.rs
#	runtime/integration-tests/src/xcm_transfers.rs
@samelamin
some dummy log statements
0a4c8f3
@samelamin
attempt 1 to add try-runtime
f93d211
@samelamin
second attempt
897729f
@samelamin
add to the cli
33353bb
@samelamin
fix warn issue
fe1cb42
@f-gate
on initialise, remove on runtime upgrade proposasl
e3a5dd9
@f-gate
Merge branch 'rococo_admin' of github.com:ImbueNetwork/imbue into roc…
eb01227 
…oco_admin
@f-gate
add the new storage version migration
c8d46b0
@f-gate
pick runtime
661c2a8
@f-gate
new migration for proposals
34b5004
@f-gate
fmt
163b02d
@f-gate
fix v3-v4 migration test
c9cdf6e
@f-gate
fix 2
4b15042
@f-gate
fix brief migration test
cfee84e
@f-gate
clippy
a078c2a
@f-gate
fmt
e01a72f
samelamin
samelamin approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@samelamin samelamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets just remove the log statements?

@samelamin
Copy link
Contributor

LGTM once build passes

@f-gate f-gate merged commit 914ed50 into main Sep 22, 2023
3 checks passed
@samelamin samelamin deleted the rococo_admin branch November 16, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samelamin samelamin samelamin approved these changes

Assignees
No one assigned
Labels
Priority | High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-gate @samelamin