-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking workflow #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for approved applicant * fmt * add ensure role to runtime --------- Co-authored-by: Sam Elamin <hussam.elamin@gmail.com>
* test * forign signer can mint * negative minting test * remove it (#285)
* autocomplete dispute where jury size = 1 * refactor tests to include jury * fmt * give briefs a jury! * fmt * fix tests from merge * remove it (#285) --------- Co-authored-by: Sam Elamin <hussam.elamin@gmail.com>
* Eoa field (#287) * new types * ensure supported currency method * brief migration, fixes * fixes * fmt * fix up benchmarks * fix brief test * update imbue image for rococo * clear votes with tests * fix merge * fix * fix * fmt * fix --------- Co-authored-by: samelamin <hussam.elamin@gmail.com>
samelamin
reviewed
Dec 8, 2023
scripts/run_benchmarks.sh
Outdated
cd ../ | ||
cargo build --locked --features runtime-benchmarks | ||
|
||
IMBUE=./target/debug/imbue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be ./target/release/imbue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #253
Also allows us the luxury of running
./scripts/run_benchmarks.sh
which will run all benchmarks, and replace the existing benchmarks in the right place.Whoop!