Improve test coverage

ImmediatePlatform · Mar 21, 2024 · 8cffd05 · 8cffd05
1 parent 4843c4f
commit 8cffd05
Show file tree

Hide file tree

Showing 2 changed files with 77 additions and 5 deletions.
diff --git a/tests/Immediate.Apis.Tests/AnalyzerTests/CustomizeEndpointUsageAnalyzerTests.cs b/tests/Immediate.Apis.Tests/AnalyzerTests/CustomizeEndpointUsageAnalyzerTests.cs
@@ -9,7 +9,7 @@ public sealed class CustomizeEndpointUsageAnalyzerTests
 {
 	[Theory]
 	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
-	public async Task ValidDefinitionShouldNotError(string method) =>
+	public async Task ValidDefinitionShouldNotWarn(string method) =>
 		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
 			$$"""
 			using System.Threading;
@@ -43,7 +43,44 @@ private static async ValueTask<int> Handle(
 
 	[Theory]
 	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
-	public async Task InvalidAccessibilityShouldError(string method) =>
+	public async Task MultipleDefinitionShouldNotWarn(string method) =>
+		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
+			$$"""
+			using System.Threading;
+			using System.Threading.Tasks;
+			using Immediate.Apis.Shared;
+			using Immediate.Handlers.Shared;
+			using Microsoft.AspNetCore.Authorization;
+					
+			namespace Dummy;
+
+			[Handler]
+			[Map{{method}}("/test")]
+			[Authorize(Roles = "")]
+			public static class GetUsersQuery
+			{
+				internal static void CustomizeEndpoint(Microsoft.AspNetCore.{|CS0234:Builder|}.IEndpointConventionBuilder endpoint)
+					=> endpoint
+						.WithDescription("");
+			
+				internal static void CustomizeEndpoint(int id)
+					=> id.ToString();
+			
+				public record Query;
+
+				private static async ValueTask<int> Handle(
+					Query _,
+					CancellationToken token)
+				{
+					return 0;
+				}
+			}
+			"""
+		).RunAsync();
+
+	[Theory]
+	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
+	public async Task InvalidAccessibilityShouldWarn(string method) =>
 		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
 			$$"""
 			using System.Threading;
@@ -77,7 +114,7 @@ private static async ValueTask<int> Handle(
 
 	[Theory]
 	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
-	public async Task InstanceMethodShouldError(string method) =>
+	public async Task InstanceMethodShouldWarn(string method) =>
 		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
 			$$"""
 			using System.Threading;
@@ -111,7 +148,7 @@ private static async ValueTask<int> Handle(
 
 	[Theory]
 	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
-	public async Task InvalidReturnShouldError(string method) =>
+	public async Task InvalidReturnShouldWarn(string method) =>
 		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
 			$$"""
 			using System.Threading;
@@ -145,7 +182,7 @@ private static async ValueTask<int> Handle(
 
 	[Theory]
 	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
-	public async Task InvalidParameterTypeShouldError(string method) =>
+	public async Task InvalidParameterTypeShouldWarn(string method) =>
 		await AnalyzerTestHelpers.CreateAnalyzerTest<CustomizeEndpointUsageAnalyzer>(
 			$$"""
 			using System.Threading;

diff --git a/tests/Immediate.Apis.Tests/GeneratorTests/InvalidCodeTests.cs b/tests/Immediate.Apis.Tests/GeneratorTests/InvalidCodeTests.cs
@@ -193,4 +193,39 @@ private static ValueTask<int> HandleAsync(
 		Assert.Empty(result.Diagnostics);
 		Assert.Empty(result.GeneratedTrees);
 	}
+
+	[Theory]
+	[MemberData(nameof(Utility.Methods), MemberType = typeof(Utility))]
+	public void AuthorizePolicyHasInvalidType(string method)
+	{
+		var driver = GeneratorTestHelper.GetDriver(
+			$$"""
+			using System.Threading.Tasks;
+			using Immediate.Apis.Shared;
+			using Immediate.Handlers.Shared;
+			using Microsoft.AspNetCore.Authorization;
+			
+			namespace Dummy;
+
+			[Handler]
+			[Map{{method}}("/test")]
+			[Authorize(Policy = 3)]
+			public static class GetUsersQuery
+			{
+				public record Query;
+
+				private static ValueTask<int> HandleAsync(
+					Query _,
+					CancellationToken token)
+				{
+					return 0;
+				}
+			}
+			""");
+
+		var result = driver.GetRunResult();
+
+		Assert.Empty(result.Diagnostics);
+		Assert.Empty(result.GeneratedTrees);
+	}
 }