Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check EM27Sensors is working after opening #415

Open
alexdewar opened this issue Nov 14, 2023 · 1 comment
Open

Check EM27Sensors is working after opening #415

alexdewar opened this issue Nov 14, 2023 · 1 comment
Assignees
@alexdewar
Labels
should_have Things that should be included in the project

Comments

@alexdewar
Copy link
Collaborator

alexdewar commented Nov 14, 2023 •
edited
Loading

Currently, if the server is not available then the device still appears to open successfully, before the HTTP request times out. It would be better to wait until at least one response has been received before designating the device as open.

This change should probably be done as part of #324, as that will also involve running devices' constructors on separate threads.
@alexdewar
Copy link
Collaborator Author

Relates to #638.

@alexdewar alexdewar added the should_have Things that should be included in the project label Oct 11, 2024
@alexdewar alexdewar self-assigned this Oct 19, 2024
@alexdewar alexdewar mentioned this issue Oct 24, 2024
Open
alexdewar added a commit that referenced this issue Oct 24, 2024
@alexdewar
EM27SensorsBase: Wait for response before signalling device is open
1f0832c 
Closes #415.
@alexdewar alexdewar mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexdewar alexdewar

Labels
should_have Things that should be included in the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexdewar