Fix time column reading for Neware and Biologic cyclers #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjholland
added
backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
biologiccycler:pyprobe/cyclers/biologic.py: Enhancedread_filemethod to handle timestamped data and convert timestamps to cumulative seconds if a specific datetime format is detected. [1] [2]Updates to
newarecycler:pyprobe/cyclers/neware.py: Added_convert_neware_time_formatmethod to handle different Neware time formats and convert them to seconds. This method is now used in theread_filemethod to simplify time conversion logic. [1] [2]Testing enhancements:
tests/cyclers/test_biologic.py: Added a new test casetest_read_file_timestampto verify the correct processing of timestamped data in thebiologiccycler.tests/cyclers/test_neware.py: Added a new test casetest_convert_neware_time_formatto ensure the new_convert_neware_time_formatmethod works as expected.Miscellaneous:
pyprobe/cyclers/biologic.py: Imported theremodule to support regular expression matching for datetime format detection.tests/sample_data/biologic/Sample_data_biologic_timestamped.txt: Added a sample data file for testing timestamped data processing in thebiologiccycler.