Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user warning when running show_image() on Windows #174

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

tomjholland
Copy link
Collaborator

This pull request includes changes to the pyprobe/plot.py file to enhance compatibility and provide warnings for potential issues on specific platforms. The most important changes include importing necessary modules and adding a warning for Windows users about a known issue with the show_image method.

Platform compatibility and warnings:

  • pyprobe/plot.py: Imported the platform and warnings modules to handle platform-specific behavior and issue warnings.
  • pyprobe/plot.py: Added a warning in the show_image method to notify Windows users about the potential for the method to hang indefinitely, suggesting the use of show() as an alternative.

Closes #145

@tomjholland tomjholland added the documentation Improvements or additions to documentation label Dec 7, 2024
@tomjholland tomjholland merged commit 54a3b89 into main Dec 7, 2024
2 checks passed
@tomjholland tomjholland deleted the fix-show_image-bug branch December 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address performance issues running Plot.show_image()
1 participant