This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Don't check if mapId parameter fits in MapFlags #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASP.NET Core checks if mapId is permissible according to the MapFlags enum. MapFlags hasn't been updated since Airship, and I don't want to cut an Impostor release right now just to fix that. It would also cause issues with mods that define additional map id's. So switch away from MapFlags completely.
miniduikboot
added a commit
to miniduikboot/Impostor
that referenced
this pull request
Sep 13, 2022
miniduikboot
added a commit
to miniduikboot/Impostor
that referenced
this pull request
Sep 13, 2022
js6pak
approved these changes
Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASP.NET Core checks if mapId is permissible according to the MapFlags enum.
MapFlags hasn't been updated since Airship, and I don't want to cut an Impostor release right now just to fix that. It would also cause issues with mods that define additional map id's. So switch away from MapFlags completely.