Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed memory cache #386

Merged
merged 13 commits into from
Oct 7, 2024
Merged

Conversation

Ingrim4
Copy link
Member

@Ingrim4 Ingrim4 commented Aug 8, 2024

Description

  • In-memory Cache Compression:
    Implemented compression of cache entries in memory to reduce the overall system resource usage, setting the stage for a gradual deprecation of disk-based caching in future updates.

  • Enhanced Debugging Tools:
    Added basic statistics to the /orebfuscator command, providing more detailed insights into cache and task queue behavior to assist with debugging.

  • Improved Config Parsing Feedback:
    Enhanced feedback for config parsing, now displaying clear messages in the console and upon admin login, making it easier to spot

Motivation and Context

Future removal of disk cache

How Has This Been Tested?

Successfully tested on spigot and paper (1.16.5, 1.20.4, 1.21)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Ingrim4 Ingrim4 requested a review from NgLoader August 29, 2024 17:40
@Ingrim4 Ingrim4 self-assigned this Aug 29, 2024
@Ingrim4 Ingrim4 changed the title WIP - Experimental compressed memory cache Experimental compressed memory cache Sep 11, 2024
@Ingrim4 Ingrim4 marked this pull request as ready for review September 11, 2024 15:43
Copy link
Member

@NgLoader NgLoader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, config files need to be updated

NgLoader
NgLoader previously approved these changes Oct 7, 2024
Copy link
Member

@NgLoader NgLoader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NgLoader
NgLoader previously approved these changes Oct 7, 2024
NgLoader
NgLoader previously approved these changes Oct 7, 2024
@Ingrim4 Ingrim4 changed the title Experimental compressed memory cache Compressed memory cache Oct 7, 2024
@Ingrim4 Ingrim4 merged commit 7de1d8e into master Oct 7, 2024
2 checks passed
@Ingrim4 Ingrim4 deleted the experimental-compressed-memory-cache branch October 7, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants