forked from lishid/Orebfuscator
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressed memory cache #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ingrim4
commented
Aug 29, 2024
orebfuscator-plugin/src/main/java/net/imprex/orebfuscator/OrebfuscatorStatistics.java
Outdated
Show resolved
Hide resolved
Ingrim4
changed the title
WIP - Experimental compressed memory cache
Experimental compressed memory cache
Sep 11, 2024
NgLoader
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, config files need to be updated
NgLoader
previously approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NgLoader
previously approved these changes
Oct 7, 2024
NgLoader
previously approved these changes
Oct 7, 2024
NgLoader
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In-memory Cache Compression:
Implemented compression of cache entries in memory to reduce the overall system resource usage, setting the stage for a gradual deprecation of disk-based caching in future updates.
Enhanced Debugging Tools:
Added basic statistics to the
/orebfuscator
command, providing more detailed insights into cache and task queue behavior to assist with debugging.Improved Config Parsing Feedback:
Enhanced feedback for config parsing, now displaying clear messages in the console and upon admin login, making it easier to spot
Motivation and Context
Future removal of disk cache
How Has This Been Tested?
Successfully tested on spigot and paper (1.16.5, 1.20.4, 1.21)
Types of Changes