Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#61] retain block order in config #69

Merged
merged 1 commit into from
Nov 3, 2020
Merged

[#61] retain block order in config #69

merged 1 commit into from
Nov 3, 2020

Conversation

Ingrim4
Copy link
Member

@Ingrim4 Ingrim4 commented Nov 3, 2020

Description

Retain block order of hiddenBlocks and randomBlocks in the config.yml after saving the config

Related Issue

#61

Motivation and Context

In the default config.yml file created by the plugin, hiddenBlocks and randomBlocks are in an arbitrary order. This makes it difficult for server owners to compare config files to see what has changed when a new version is released.

How Has This Been Tested?

manually tested

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Ingrim4 Ingrim4 self-assigned this Nov 3, 2020
@Ingrim4 Ingrim4 added this to the 5.1.2 milestone Nov 3, 2020
@Ingrim4 Ingrim4 merged commit 09c9cc7 into master Nov 3, 2020
@Ingrim4 Ingrim4 deleted the 61-inconsistent-config-write-order branch November 3, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NgLoader NgLoader NgLoader approved these changes

Assignees

@Ingrim4 Ingrim4

Labels
None yet
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Ingrim4 @NgLoader