Improve Digital Bid Adapter: Bid floor is sent in USD when possible #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **Type:** Fix * **Scope:** improvedigitalBidAdapter * **Subject:** Bid floors are always converted to USD. * **Details:** * Adds `DEFAULT_CURRENCY` variable which is set to USD * Adds `convertBidFloorCurrency` function which in used to convert the bid floor when both `imp.bidfloor` and `imp.bidfloorcur` are present, and `imp.bidfloorcur` is not equal to the adapter's `DEFAULT_CURRENCY`; * **Breaks:** N/A
…ed to USD; * Removes rounding of bid floor when converting its currency to USD;
lyubomirshishkov
changed the title
lyubomirshishkov
changed the title
jbartek25
requested changes
Oct 11, 2024
* remove redundant checks for type and NaN from `convertBidFloorCurrency` function
jbartek25
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Bid Floors are currently always sent in their original currency to Improve Digital, which is problematic in cases when the currency is not supported by the SSP. The proposed change converts all Bid Floors which are not already in USD to USD when possible. If the Bid Floor cannot be converted by Improve Digital's Bid Adapter the Bid Floor is sent as is.
Other information
Original Issue in prebid/Prebid.js - prebid#12238