implemented changes to enable latest feature upgrades #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ishihanvcs
commented
Aug 24, 2023
ishihanvcs
commented
- support for mtype
- support for .GPP
- support for audio
jbartek25
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Please remove the logic which checks whether the imp is multi-format or not. I tried to explain it in our call but let me try again: the adapter should always anticipate correct response from our own ad server. it means, the logic should be pretty simple: is there mtype? Use it. If not, fall back to the old logic. Right now the ad server sets mtype only for multiformat but this might change in the future without telling. On another note, for converting mtype to bidtype you can use getMediaTypeForBid from utils.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.