You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default version of SdFat installed by the Arduino Libraries manager is now V2. However, there are a few small changes between V1 and V2 that makes GUIslice no longer compile. In particular, the SdFatSoftSpi template is no longer used (see https://github.com/greiman/SdFat/blob/master/examples/SoftwareSpi/SoftwareSpi.ino#L22) and instead a different (but almost identical) class template, and the preprocessor symbol for ENABLE_SOFTWARE_SPI_CLASS no longer exists.
Device hardware
MCU: Irrelevant, effects all SdFat Soft platforms. But I was using Due.
Display with link: It's the same display as mentioned in this issue
Display works correctly with standalone display driver library examples (eg. TFT_eSPI graphicstest, Adafruit graphicstest, etc.) without GUIslice: it does.
Touch works correctly with standalone touch library examples without GUIslice: It does.
I was able to get everything working after I downgraded to v1
Expected behavior
A description of what you expected to happen
It would be nice to compile (or at least throw an error message explaining what to do) if v2 is detected in the preprocessor, because I spent almost 2 hours trying to debug the downgrade. I can even make a patch for this.
The text was updated successfully, but these errors were encountered:
Thank you for catching this and posting a PR, Steve! (merged)
Although the SdFat versioning has a bit of inconsistency, I have now tried adding a check for v2.0.3 (thanks to your integer version request to Bill) and utilize the new API.
If you get a chance to try out the revised GUIslice implementation, let me know. It compiles on my end, but I haven't tested it on the hardware yet. Note that users of SdFat v2 would need to set SPI_DRIVER_SELECT 2 in their SdFatConfig.h.
Describe the bug
The default version of SdFat installed by the Arduino Libraries manager is now V2. However, there are a few small changes between V1 and V2 that makes GUIslice no longer compile. In particular, the SdFatSoftSpi template is no longer used (see
https://github.com/greiman/SdFat/blob/master/examples/SoftwareSpi/SoftwareSpi.ino#L22) and instead a different (but almost identical) class template, and the preprocessor symbol for ENABLE_SOFTWARE_SPI_CLASS no longer exists.
Device hardware
ard-shld-generic1_35_touch1.h
Please confirm whether:
I was able to get everything working after I downgraded to v1
Expected behavior
A description of what you expected to happen
It would be nice to compile (or at least throw an error message explaining what to do) if v2 is detected in the preprocessor, because I spent almost 2 hours trying to debug the downgrade. I can even make a patch for this.
The text was updated successfully, but these errors were encountered: