Skip to content

Pull requests

amalija-ramljak edited this page Nov 24, 2021 · 2 revisions

How to make a PR

Create a PR

Create a PR out of the branch

PR content

What changes were made?

  • list of changes made, e.g.
    • added new dependency, x
    • added new route, x
    • fixed alignment of x
    • fixed title of x

How to see the changes?

  • how to run the code, e.g.
    • run yarn install
    • run yarn dev --host and open on phone
    • go to route /xy

How to test their stability and verify that something else was not broken?

  • consider what your changes could affect elsewhere in the code

PR formatting

Code (incl. mentioning variable names or values)

  • inline code (single backtick)
  • code blocks (triple backtick)

Filenames

  • inline code (single backtick)

Routes

  • inline code (single backtick)

Reviewer

Amalija Ramljak

  • frontend
  • API
  • database

Marijan Smetko

  • deployment related changes
  • content

Home

Organisation
Development
Clone this wiki locally