Fix catastrophic backtracking in BACKSLASH_URL_RE #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a Catastrophic Backtracking issue with
BACKSLASH_URL_RE
by updating the regex to match the format used by the bracket regex.All current tests pass before and after the change.
Proof of concept script
Before fix
./iocextract_catastrophic_backtracking_poc.py Starting url extraction... Extracted 9 unique urls in 9.963629484176636 seconds
After fix
./iocextract_catastrophic_backtracking_poc.py Starting url extraction... Extracted 9 unique urls in 0.009938955307006836 seconds
I wasn't able to pinpoint exactly what in the sample text was triggering the backtracking but the longer the text is the exponentially longer the url extraction would take. The sample text above is 3.7k and takes <10 seconds, the original text I was having issues with was ~26k and extraction took almost 3 minutes.
Fixes #52