This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Fix TempFile usability #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #17 +/- ##
=========================================
Coverage ? 20.8%
=========================================
Files ? 8
Lines ? 399
Branches ? 69
=========================================
Hits ? 83
Misses ? 309
Partials ? 7
Continue to review full report at Codecov.
|
IncPlusPlus
force-pushed
the
bugfix/fix_tempfile_usability
branch
from
18e177e to
6c4f937
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TempFile class so that files can be extracted from JARs outside of just btb-io. Previously, the protection domain of TempFile was used as the domain to fetch files from. This resulted in only files within the IO module's JAR being accessible. One should theoretically be able to access more than that now.