Mute player before recording the demo #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the command to mute yourself isn't replayed during demo playback.
This class will still be kept around for use with demos recorded before the relevant changes to DemoRecordingHelper were made.
IncPlusPlus
added
the
🛠 Improvement
If you play the demo back in the same game session after recording, you voice will still be muted. If you restart your game AND THEN play the demo, you will no longer be muted. For this purpose, I've ensured that the messages left in the console will be recorded still for DemoPlaybackHelper to pick up on. If you've restarted your game since recording the demo, it won't be necessary to have this tool running. This is only necessary if you watch the demo immediately after recording it.
|
Tested and confirmed working. |
IncPlusPlus
deleted the
improvement/mute-player-before-recording-starts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, DemoRecordingHelper will run the command to mute the person recording the demo with after the demo recording begins. The problem with this is that the console command to mute yourself is recorded while the demo is recording. This means that when you play the demo back, that same command will execute again and mute your own voice.
In hindsight it would have been way better to run the command that mutes myself before the demo recording starts. That way, the demo doesn't even need the playback helper running for my own voice to be audible. So that's exactly what I've decided to start doing!