Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a complete crash when DemoRecordingHelper fails #40

Merged
merged 2 commits into from
Jan 2, 2021

Conversation

IncPlusPlus
Copy link
Owner

There's no reason to completely fail when DemoRecordingHelper encounters an error.

@IncPlusPlus IncPlusPlus added this to the 1.1.1 milestone Jan 2, 2021
@IncPlusPlus IncPlusPlus self-assigned this Jan 2, 2021
@github-actions github-actions bot added the bug Something isn't working label Jan 2, 2021
@IncPlusPlus IncPlusPlus force-pushed the bug/prevent-crash-when-DemoRecordingHelper-fails branch from 7b1b0b8 to 7054df9 Compare January 2, 2021 03:00
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #40 (91ab7c4) into main (043178d) will decrease coverage by 0.25%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   58.53%   58.27%   -0.26%     
==========================================
  Files          15       15              
  Lines         463      465       +2     
  Branches       49       50       +1     
==========================================
  Hits          271      271              
- Misses        183      184       +1     
- Partials        9       10       +1     
Impacted Files Coverage Δ
src/services/DemoRecordingHelper.ts 15.00% <0.00%> (-0.13%) ⬇️
src/utils/DemoNamingHelper.ts 45.45% <0.00%> (ø)
src/utils/TimeoutPromise.ts 66.66% <66.66%> (-3.93%) ⬇️
src/utils/SubscriberManager.ts 80.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043178d...91ab7c4. Read the comment docs.

@IncPlusPlus IncPlusPlus merged commit c8c706d into main Jan 2, 2021
@IncPlusPlus IncPlusPlus deleted the bug/prevent-crash-when-DemoRecordingHelper-fails branch January 2, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant