feat: Update to geth 1.13 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenta-mori3322
suggested changes
Mar 26, 2024
There was a problem hiding this comment.
@amaury1093
I see that the latest go ethereum version is v1.13.14. Is there any specific reason to use v1.13.5? Rest of the stuff would be looking like a code diff using tools.
Main reason is to keep exactly the version that Zama uses: https://docs.zama.ai/fhevm-go/getting-started/integration. I also tried updating to latest version, but got errors: I can try to fix these errors, but I also think it's fine to pin v1.13.5. What do you think? Is there any big improvement in v1.13.14 that you'd like to include? |
|
@amaury1093 make sense. Already started extacting the core vm from v1.13.14. LGTM. Approved. |
kenta-mori3322
approved these changes
Mar 26, 2024
lovenoble
approved these changes
Mar 26, 2024
amaury1093
added a commit
that referenced
this pull request
Apr 5, 2024
* update geth * fix * use zbc geth * fix pebble * Fix statedb * fix some * fix x/evm * make it build * skip CI * Fix test name * Run some tests * run actions * skip integration tests * skip failing test * enable cancun
amaury1093
added a commit
that referenced
this pull request
Apr 5, 2024
* update geth * fix * use zbc geth * fix pebble * Fix statedb * fix some * fix x/evm * make it build * skip CI * Fix test name * Run some tests * run actions * skip integration tests * skip failing test * enable cancun
amaury1093
added a commit
that referenced
this pull request
Apr 15, 2024
* feat: Update to geth 1.13 (#1) * update geth * fix * use zbc geth * fix pebble * Fix statedb * fix some * fix x/evm * make it build * skip CI * Fix test name * Run some tests * run actions * skip integration tests * skip failing test * enable cancun * feat: Add RPC client for EVM methods * wip * Implement basic server and client * remove useless interface * Rename * comments * chore: add leftovergas to args * cliean code * fix build * fix * fixes * chore: remove statedb in ethermint and change it to be rpc call * Small changes and renames --------- Co-authored-by: kenta-mori3322 <kenta.mori32@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Update geth to use 1.13.5.
To make sure I didn't forget anything that Zama did (they updated geth 1.10 to 1.13 on SDK 0.46), I used a git diff tool (Git Tree on VSCode) to compare the following commits on zbc-ethermint:
https://github.com/Inco-fhevm/zbc-ethermint/commit/9ebc339734b9cd1ba59b36942b71da94b4962382 .. https://github.com/Inco-fhevm/zbc-ethermint/commit/0a736a36bff125b559aaa36d2b08d27be80c8033
and make sure all those changes are reflected in this PR.
Once this is merged, there's a PR to update on inco-monorepo: https://github.com/Inco-fhevm/inco-monorepo/pull/13
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)