Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong UN M.49 region for Myanmar #124

Closed
alanorth opened this issue Nov 28, 2022 · 0 comments · Fixed by #125
Closed

Wrong UN M.49 region for Myanmar #124

alanorth opened this issue Nov 28, 2022 · 0 comments · Fixed by #125

Comments

@alanorth
Copy link
Contributor

I just noticed that country_converter currently considers Myanmar to be in the UN M.49 region "Eastern Asia":

$ ipython
...

In [1]: import country_converter as coco

In [2]: coco.convert("Myanmar", to="UNRegion")
Out[2]: 'Eastern Asia'

According to the UN M.49 website and data dump Myanmar should be in "South-eastern Asia".

Screenshot 2022-11-28 at 17-22-43 UNSD — Methodology-fs8
alanorth added a commit to alanorth/country_converter that referenced this issue Nov 28, 2022
@alanorth
country_converter/country_data.tsv: fix Myanmar
ec55338 
According to the UN M.49 data Myanmar is in South-eastern Asia, not
Eastern Asia.

Fixes: IndEcol#124
@alanorth alanorth mentioned this issue Nov 28, 2022
Merged
konstantinstadler pushed a commit that referenced this issue Jan 13, 2023
@alanorth
country_converter/country_data.tsv: fix Myanmar (#125)
49dc648 
According to the UN M.49 data Myanmar is in South-eastern Asia, not
Eastern Asia.

Fixes: #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

country_converter/country_data.tsv: fix Myanmar alanorth/country_converter
1 participant
@alanorth