feat: add flash mint wrapped #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
Sep 17, 2024
janndriessen
commented
Sep 18, 2024
janndriessen
commented
Sep 30, 2024
janndriessen
commented
Sep 30, 2024
janndriessen
commented
Sep 30, 2024
| return assets | ||
| } catch { | ||
| // TODO: apply slippage to issuance units amount (for all none erc4262) | ||
| return issuanceUnits |
There was a problem hiding this comment.
@pblivin0x for the presale I can just use issuance units here or should I still apply a slight slippage by default?
There was a problem hiding this comment.
DebtIssuanceModuleV3 will lose the tokenTransferBuffer of wei on each component
Rebasing components will "lose" however much their accounting is stale by (Aave V3 USDC and Compound V3 USDC)
So some slippage needs to be applied always, for different reasons
# Conflicts: # package-lock.json # package.json # src/quote/provider/index.test.ts
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlashMintWrappedcontract for icUSDicUSDtokenTODOs