Try to parse shebang lines with a variable #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey cool, it looks like this fixes parsing of Lines 39 to 41 in 449a1a5 |
|
I bumped the tree-sitter version since after you opened this PR, just FYI you might need to rebase and regenerate. |
|
I regenerated when I merged main, it looks like I got it right, whew. |
|
Awesome! FYI you have two different commit emails (barrettnexus and sony), not sure if you care about that. Not a problem here of course, I'll squash merge whenever you're ready (unless you just want to rebase to drop the merge commit) |
leon-barrett
force-pushed
the
leon-shebang-variable
branch
from
92d458c
to
06f7884
Compare
|
Okay, I've rebased, using my personal email. Thanks for noticing. Feel free to merge when you're ready. |
I believe this fixes this issue: IndianBoy42#175
leon-barrett
force-pushed
the
leon-shebang-variable
branch
from
ff2952e
to
be21c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes this issue:
#175
I came to believe that the _opaque_shebang regex was eating too much and causing a parse error. I'm not sure I like this fix, but I'm a noob at tree-sitter, and maybe these breadcrumbs lead someone more experienced to a fix.