Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisCluster support + use same redis client if already setup in redis_queue plugin #9

Merged
merged 6 commits into from
Oct 24, 2022

Conversation

shaangill025
Copy link
Contributor

Signed-off-by: Shaanjot Gill gill.shaanjots@gmail.com

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: shaangill025 <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
@TheTechmage
Copy link
Collaborator

Okay, it looks like the network already exists, so all we needed were the environment variables 🤔

Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
@shaangill025
Copy link
Contributor Author

Okay, it looks like the network already exists, so all we needed were the environment variables 🤔

I've made the update, can you re-run the workflows.

Copy link
Collaborator

@TheTechmage TheTechmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the failures out of the way, LGTM

@TheTechmage TheTechmage merged commit a192adb into Indicio-tech:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants