Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #2434: Change DIDExchange States to Match rfc160 #151

Conversation

anwalker293
Copy link

Includes fixes to hyperledger#2434. Changes all ConnRecord.States to match that of rfc160.

Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! A couple minor comments.

aries_cloudagent/protocols/didexchange/v1_0/manager.py Outdated Show resolved Hide resolved
aries_cloudagent/protocols/didexchange/v1_0/manager.py Outdated Show resolved Hide resolved
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
@dbluhm dbluhm force-pushed the fix/didexchange-responder-terminal-state-to-active branch from 31dad46 to 70f59cc Compare September 5, 2023 19:00
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
@dbluhm
Copy link
Member

dbluhm commented Sep 6, 2023

Closing in favor of upstream PR. Thanks and nice work!

@dbluhm dbluhm closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants