Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New format_markdown() function #139

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matcasti
Copy link

In response to issue #1 this function try to solve the need of a parser function for expression objects returned by any of {ggtatsplot} or {statsExpressions} functions for reporting purposes in R Markdown

I hope this contribution will be helpful!

In response to issue IndrajeetPatil#1 this function try to solve the need of a parser function for expression objects returned by any of `{ggtatsplot}` or `{statsExpressions}` functions for reporting purposes in R Markdown
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #139 (109574f) into master (764441f) will decrease coverage by 4.439%.
The diff coverage is 0.000%.

❗ Current head 109574f differs from pull request most recent head 92cb05d. Consider uploading reports for the commit 92cb05d to get more accurate results

@@              Coverage Diff              @@
##            master      #139       +/-   ##
=============================================
- Coverage   99.778%   95.339%   -4.439%     
=============================================
  Files           12        13        +1     
  Lines          451       472       +21     
=============================================
  Hits           450       450               
- Misses           1        22       +21     
Impacted Files Coverage Δ
R/format_markdown.R 0.000% <0.000%> (ø)

@IndrajeetPatil
Copy link
Owner

Hi Matias,

Thanks a lot for working on this!

I am going to let this sit for a bit because I am not convinced that this is the right way to go.

Note that the package supports many more tests, which introduces a lot more symbols than currently covered in this PR, and it will continue to grow as more tests are supported. So I am wondering if there exists a more general solution to address the issue than the current brute force (and more fragile) way to deal with it.

https://github.com/IndrajeetPatil/statsExpressions/blob/master/R/switch_functions.R

I will sleep on this a bit more and get back to you! 😄

@matcasti
Copy link
Author

No problem! If there's anything I can do to help, don't hesitate to let me know 💪

@IndrajeetPatil IndrajeetPatil marked this pull request as draft July 5, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants