Update the UI to support the modified outages and entities API #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityType and entityCode have been changed from in-path parameters to query parameters, so we need to update our API requests accordingly. Obviously, this change needs to be deployed at the same time that the corresponding API change is deployed.
Prior to this, we only drew snaplines if the time series data arrived AFTER the event data. If the event data arrived later, there was no trigger to re-draw the graph to include the newly arrived event information.
As with the entities/ API update, make sure we roll this change out at the same time as we roll out the corresponding API changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had to make some changes to the way that the
outages/andentities/API methods work (specifically moving entityType and entityCode to be query parameters instead of in-path ones).This PR updates any calls to these APIs in the UI code to use the new parameter structure.
It also includes a fix for a bug I found during testing where alert bands would not be drawn on the time series graphs if the
outages/query completed after theraw/signals/query.