Add ESLint configs for IDE compatibility #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longer term, we do need to start running upgraded versions of our dependencies -- mainly for security reasons, but also just for maintainability as older packages may become unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In its current state, IODA UI has some IDE linter issues. These issues do not impact the build process, but they impair developer productivity. See screenshot below for an example:
This change adds ESLint configs via a new
.eslintrc.jsonfile. To enable the required babel presets, a few babel packages were installed. I also updated thenode-sassversion.Testing
All changes were pushed first to a
fix/linterbranch. These changes were then pulled in onlevanzoand built. The public dev site was reloaded successfully with the new build script present, indicating that the changes were successfully deployed.Notes
To ensure the success of this change, delete
node_modules,package-lock.json, andyarn.lock. Then, runyarn installto get the updated dependencies.