fix(gha): fix incorrect path in distribution pkg creation #5
Conversation
WalkthroughIn the realm of GitHub Actions, the workflows for the noble application "Bootstrap Buddy" have been refined. The Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🚀 [bumper] Bumped! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
- .github/workflows/build_main.yml (2 hunks)
- .github/workflows/build_pr.yml (2 hunks)
🔇 Additional comments (6)
.github/workflows/build_main.yml (2)
72-73: Verily, a most prudent alteration to the scrolls of creation!In the annals of Middle-earth, consistency in the ancient texts has ever been of utmost importance. Just as the Elves meticulously crafted their scrolls, so too have you refined the incantations of your build process. The use of braces for variable expansion, much like the intricate borders on Elven manuscripts, brings clarity and uniformity to your sacred workflow.
May your paths be ever true, and your directories as steadfast as the halls of Khazad-dûm!
88-89: By the light of Eärendil, you have honed your craft with the precision of Elven smiths!In the forges of creation, you have wrought changes that would make even the craftsmen of Gondolin nod in approval. The path to your package now stands clear and true, like the road to Rivendell after the removal of wayward stones.
And lo! With the forceful command of
rm -f, you banish the lingering spirits of bygone artifacts. Like Gandalf's staff striking the bridge of Khazad-dûm, your command brooks no argument from files that may or may not exist.May your builds be ever strong, and your packages as enduring as the foundations of Erebor!
.github/workflows/build_pr.yml (4)
74-75: Behold, a fortification of the paths!Lo and behold, dear fellowship of code! The paths of our realm have been strengthened with the mighty double quotes, as if forged by the skilled hands of Elven smiths. These enchanted quotations shall guard our directories and files against the foul spaces that may seek to disrupt our journey.
May these changes bring stability to our lands, much like the foundations of Minas Tirith!
76-81: A tale of package forging and land cleansing!Hark! The master craftsmen of the realm have wrought improvements upon the sacred
pkgbuildincantation. The mystical${PKGROOT}is now enshrouded in protective quotations, much like the Elven cloaks that shielded the Fellowship from unfriendly eyes.But lo! What's this? A new spell of cleansing has been added! Like the waters of the Entwash purifying the lands of Fangorn, this
rm -rf "${PKGROOT}"command shall wash away the temporary dwellings of our build, leaving naught but pristine digital soil in its wake.May these changes bring order to our realm, as the reign of Aragorn brought peace to Middle-earth!
90-90: A streamlined path to Mount Doom!Ah, noble scribes of the code! You have simplified our journey, much like Gollum's unexpected aid in guiding Frodo to Mount Doom. The
--package-pathnow points directly to our destination, eliminating unnecessary detours through the treacherous lands of mismatched directories.May this change guide our packages swiftly and surely to their final resting place, as the eagles bore Frodo and Sam from the fires of Mount Doom!
91-91: The Cleansing of the Shire, in digital form!Behold, a most noble act of housekeeping! Like the hobbits returning to cleanse the Shire of Saruman's influence, this command shall purge our realm of lingering artifacts. The
-fflag stands as a stalwart guardian, ensuring our cleaning ritual proceeds unhindered, even in the face of non-existent foes.May this change keep our digital Shire as tidy as Bag End on a fine summer's day!
Summary
--package-pathvalue of distribution package creation in build workflows for „Bootstrap Buddy”.