Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board configuration for 063-ble #90

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Board configuration for 063-ble #90

merged 4 commits into from
Sep 26, 2023

Conversation

jaenrig-ifx
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

  • Moved general configuration to board configuration
  • Dimension gc_heap_size as per board
  • Dimension flash as per MCU
  • Removed SSL and related featuers from 063-BLE to reduce memory

Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40

Copy link
Member

@NikhitaR-IFX NikhitaR-IFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good! 🚀


#define MICROPY_GC_HEAP_SIZE (256 * 1024) // 256 KB

#define MICROPY_PY_HASHLIB (1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I get it right these are defines for mpy extended modules which means they are by default already defined (as 0?) in one of the mpy extmod files. Only if they have to be redefined to 1 , then needs to be included either common to port or board. or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I just have removed them from the file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only kept in the old board, and removed it in the 063-BLE.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!


#define MICROPY_GC_HEAP_SIZE (64 * 1024) // 64 KB

#define MICROPY_PY_HASHLIB (0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment in previous board mpconfigboard.h

Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
@jaenrig-ifx jaenrig-ifx merged commit 72bcd85 into multi-board-support Sep 26, 2023
26 checks passed
@jaenrig-ifx jaenrig-ifx deleted the 063-ble branch September 26, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants