Machine clean & docs update #99
Conversation
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
| @@ -411,8 +412,17 @@ MISO P9_1 P6_1 P10_1 | |||
| SCK P9_2 P6_2 P10_2 | |||
| ===== =========== ============ ============ | |||
|
|
|||
| .. | |||
|
|
|||
| TODO: This is only applicable to the CY8CPROTO-062-4343W. This does not belong here. | |||
There was a problem hiding this comment.
I agree this is specific to only proto board. But also, in mpy official docs other ports which support multiple boards still have I guess the most common board reference (pinouts etc.) in quickref. But we will have to move around our docs a bit. Maybe have common port docs and point out to getting started with different boards or something.
There was a problem hiding this comment.
Agree, other ports show only one board. We have to discuss this in the strategy, and find our compromise for maintainability - user friendliness.
docs/psoc6/quickref.rst
Outdated
| @@ -425,7 +435,7 @@ SPI object is created with default settings or settings of previous initializati | |||
| :: | |||
|
|
|||
| from machine import SPI | |||
| spi = SPI(0) # Default assignment: id=0, sck=P9_2 ,MOSI=P9_0, MISO=P9_1, baudrate=1000000, Polarity=0, Phase=0, bits=8, firstbit=SPI.MSB | |||
| spi = SPI(0, sck='P11_2', mosi='P11_0', miso='P11_1') # Default assignment: id=0, sck=P9_2 ,MOSI=P9_0, MISO=P9_1 | |||
There was a problem hiding this comment.
Here pins and comment is mismatched. I think it should be
spi = SPI(0, sck='P9_2', mosi='P9_0', miso='P9_1') # Default assignment: id=0, baudrate=1000000, Polarity=0, Phase=0, bits=8, firstbit=SPI.MSB
Signed-off-by: enriquezgarc <enriquezgarcia.external@infineon.com>
jaenrig-ifx
force-pushed
the
machine_clean_docs
branch
from
2898339 to
567a339
Compare
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
To review after #98.